Add int-based rounding functions #637
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce functions such as
int_round_asas alternatives for everyfunction in the
round_asfamily. The new functions use bespoke logic,while the old ones wrap STL functions such as
std::round. This givesthe new functions two advantages:
constexpr.It feels goofy for an integer input to have to go through floating
point, and all of its weirdness at large values.
I've never seen anything like this before, probably because the notion
of "rounding" an integer type makes little sense in general: it's
already an integer. In the realm of unit conversions, though, we do
have applications for this.
Helps #243. A future PR will add "explicit Rep" versions of these.