Skip to content

Conversation

@atlassian
Copy link
Contributor

@atlassian atlassian bot commented Dec 11, 2025

No description provided.

@atlassian-cla-bot
Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
[email protected]

Already signed the CLA? To re-check, try refreshing the page.

<p style={{ fontSize: '11px' }}>{description}</p>
<div style={{ display: 'flex', alignItems: 'flex-start', gap: '8px', flex: '1' }}>
<div className="prompt-settings-logo">{icon}</div>
<div id="prompt-settings-context" style={{ flex: '1' }}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Code Bugs

Remove the id attribute as multiple PromptSettingsItem components render simultaneously, creating duplicate IDs in the DOM which violates HTML standards.

Details

📖 Explanation: The PromptSettingsItem component is rendered multiple times in the popup (for Plan, Full-Context mode, and YOLO settings), but each instance uses the same id="prompt-settings-context". This creates multiple DOM elements with identical IDs, which is invalid HTML and can cause issues with accessibility tools and JavaScript selectors.

Suggested change
<div id="prompt-settings-context" style={{ flex: '1' }}>
<div style={{ flex: '1' }}>

Uses AI. Verify results. Give Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant