PES-3558 : fix: update extraction of alias from sql file #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharma-shreyas
requested review from
ArpitShukla12,
Jaagrav,
bichitra95 and
rittikdasgupta
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original regex can take too long to execute. Extracting the config first and then running it would be much more efficient.
Same fix was made for gitlab integration here: atlanhq/dbt-action#129
Jira: https://atlanhq.atlassian.net/browse/PES-3558
Have tested the action on my fork of this repo with this fix here: https://github.com/sharma-shreyas/dbt-action/pull/10
(used the customer's failing sql files)