chore: make aiohttp an optional dependency for REST #919
Open
AayushSaini101 wants to merge 1 commit intoatlanhq:mainfrom
Open
chore: make aiohttp an optional dependency for REST #919AayushSaini101 wants to merge 1 commit intoatlanhq:mainfrom
AayushSaini101 wants to merge 1 commit intoatlanhq:mainfrom
Conversation
AayushSaini101
requested review from
AtMrun,
firecast and
inishchith
as code owners
inishchith
reviewed
Jan 3, 2026
Comment on lines
+8
to
+22
| if TYPE_CHECKING: | ||
| import aiohttp | ||
|
|
||
|
|
||
| def _get_aiohttp() -> "aiohttp": | ||
| """Lazy import aiohttp with helpful error message.""" | ||
| try: | ||
| import aiohttp | ||
|
|
||
| return aiohttp | ||
| except ImportError: | ||
| raise ImportError( | ||
| "aiohttp is required for REST authentication. " | ||
| "Install it with: pip install 'atlan-application-sdk[rest]'" | ||
| ) from None |
Member
There was a problem hiding this comment.
(nit) this block shouldn't be between two imports - ref
inishchith
reviewed
Jan 4, 2026
Member
inishchith
left a comment
inishchith
left a comment
There was a problem hiding this comment.
I think #771 is stale since the introduction of httpx into the codebase. we might need to review the outcomes we want from the ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #771
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance