Skip to content

Conversation

@aldol07
Copy link

@aldol07 aldol07 commented Oct 8, 2024

This update introduces comprehensive comments and function descriptions to the background.js file, enhancing the overall readability and maintainability of the codebase.

@aldol07
Copy link
Author

aldol07 commented Oct 8, 2024

Screenshot 2024-10-08 185515
I am getting this error kindly fix this

@atj393
Copy link
Owner

atj393 commented Oct 8, 2024

@aldol07 This is a normal pipeline error based on the review rules. I will check and udpate. Thanks.

@atj393 atj393 self-requested a review October 8, 2024 13:52
@aldol07
Copy link
Author

aldol07 commented Oct 8, 2024

How much time it will take?

Copy link
Owner

@atj393 atj393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldol07 Line comments in unnecessary places are not acceptable. Thank you.
This PR must be closed without merging in my opinion. Sorry.

@aldol07
Copy link
Author

aldol07 commented Oct 9, 2024

I can change it accordingly can you describe more what type of comments you want

@atj393
Copy link
Owner

atj393 commented Oct 9, 2024

@aldol07 we are more looking into the direction of jsdoc comments. https://jsdoc.app/about-getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants