Skip to content

Conversation

@nefarius
Copy link

@nefarius nefarius commented Dec 3, 2023

Added Docker support 😃

@nefarius nefarius mentioned this pull request Dec 3, 2023
@atauenis
Copy link
Owner

atauenis commented Dec 4, 2023

I'm don't see ability how to provide custom configuration files into the image, like able in https://github.com/way5/docker-webone .

@nefarius
Copy link
Author

nefarius commented Dec 4, 2023

Indeed, maybe @way5 should just PR his already maintained solution here into upstream and we close this one?

Saves us duplicate work.

@way5
Copy link
Contributor

way5 commented Dec 7, 2023

@nefarius , no rush. I believe @atauenis meant something more comprehensive rather than this or what I've done. I think this "feature" will resolve itself within future releases. :)

@nefarius
Copy link
Author

nefarius commented Dec 8, 2023

I can sure make it more sophisticated if desired 😜

@atauenis
Copy link
Owner

atauenis commented Dec 8, 2023

I've meaning this:

docker run -d -p 8080:8080 -v /your/local/webone.config:/home/webone --name CONTAINER_NAME IMAGE_NAME

And I'm not a professional user of Docker, don't know is it's possible with @nefarius dockerfile (don't see anything about unpack directory), probably impossible. This is a nice feature as sometimes it's useful to change some settings of WebOne.

@nefarius
Copy link
Author

nefarius commented Dec 8, 2023

The Dockerfile doesn't need to know the mount paths the user may or may not use, it can be annotated though. I'll add an example compose file to the PR later.

@way5
Copy link
Contributor

way5 commented Dec 8, 2023

I can sure make it more sophisticated if desired 😜

Me either :)
Though, I mean the new functionality in future would tell us what it must look like
It's really not necessary to push the docker build for now I believe. Everyone can make its own script that fits to the needs if desired or use mine or that you wrote. This doesn't matter for now.
@atauenis 's beautiful idea will show us the way ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants