Skip to content

[Rubin] Fix typo in is_new #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulienPeloton merged 1 commit into from
Jan 29, 2026
Merged

[Rubin] Fix typo in is_new #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions fink_filters/rubin/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,16 @@ def b_is_fading(
return is_fading


def b_is_new(midpointMjdTai: pd.Series, midpointMjdTaiFink: pd.Series) -> pd.Series:
def b_is_new(
midpointMjdTai: pd.Series, firstDiaSourceMjdTaiFink: pd.Series
) -> pd.Series:
"""Return alerts for which the underlying object is seen for the first time by Rubin

Parameters
----------
midpointMjdTai: pd.Series
Alert emission date
midpointMjdTaiFink: pd.Series
firstDiaSourceMjdTaiFink: pd.Series
MJD for the first detection by Rubin. Temporary
replacement for diaObject.firstDiaSourceMjdTai
which is not yet populated by the project.
Expand All @@ -244,5 +246,5 @@ def b_is_new(midpointMjdTai: pd.Series, midpointMjdTaiFink: pd.Series) -> pd.Ser
out: pd.Series of booleans
True if new. False otherwise
"""
is_new = (midpointMjdTai - midpointMjdTaiFink) == 0
is_new = (midpointMjdTai - firstDiaSourceMjdTaiFink) == 0
return is_new