-
Notifications
You must be signed in to change notification settings - Fork 42
715/pictogram caching improvements #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…sorigin attribute handling everywhere - needed to correctly fetch images and determine if they can be screenshotted for thumbnail or not
…l2canvas - better handling of images in screenshot generation
…k for extension, don't rely on request.destination, because html2canvas / html-to-image don't make image-destination requests
…quests to ensure that cache keys are matching later, using fixed pre-defined strategies, KNOWN_CORS_IMAGE_APIS to decide if a request is done in "cors" mode or not
… failed urls to back of current list and don't try again immediately, limit maximum tries, debounce saving current list to localStorage only every 5s
…atic build workflow
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
…s() are finished
…heck for constant also for clarity
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
…r current controller and prevent attaching a new event listener for each call to getController()
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
…er writes (or writes too late) in a long caching process
…g (preventing everything lost if there is a fast page reload after caching start)
…use static list of APIs only for decision if request is an image
…igin), fallback to no-cors
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
…ition between service workers - only update after user confirms or page reload, no direct "skipWaiting()"
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr |
#715