Skip to content

Another round of toolchain/platform improvements#803

Open
dzbarsky wants to merge 2 commits intomainfrom
zbarsky/bumps
Open

Another round of toolchain/platform improvements#803
dzbarsky wants to merge 2 commits intomainfrom
zbarsky/bumps

Conversation

@dzbarsky
Copy link
Collaborator

Changes are visible to end-users: no

Test plan

existing tests

toolchains = use_extension("@rules_rs//rs/experimental/toolchains:module_extension.bzl", "toolchains", dev_dependency = IS_RELEASE)
toolchains.toolchain(
edition = "2024",
version = "1.93.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also bumped your compilers for ya while i'm here

@aspect-workflows
Copy link

aspect-workflows bot commented Feb 27, 2026

Bazel 8 (Test)

⚠️ Buildkite build #2654 failed.


Bazel 9 (Test)

⚠️ Buildkite build #2654 failed.


Bazel 8 (Test)

e2e

⚠️ Buildkite build #2654 failed.


Bazel 9 (Test)

e2e

⚠️ Buildkite build #2654 failed.


Bazel 8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 444ms.

@dzbarsky dzbarsky force-pushed the zbarsky/bumps branch 4 times, most recently from 01acb2d to 18fa719 Compare February 28, 2026 18:25
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dzbarsky
❌ aspect-marvin
You have signed the CLA already but the status is still pending? Let us recheck it.

@arrdem
Copy link
Collaborator

arrdem commented Mar 3, 2026

Blocked on e2e test regression.

@dzbarsky
Copy link
Collaborator Author

dzbarsky commented Mar 3, 2026

Blocked on e2e test regression.

yeah, it's because the libc constraints you define are different than the @llvm ones. I'll pick this up again after we merge the @platforms_contrib shared ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants