Merged
Conversation
tomghuang
force-pushed
the
fix-strtol0x-param-width-warnings
branch
from
5e07cf7 to
9e73146
Compare
The gcc versions older than 4.3 cannot build the current code base without warnings, which are treated as errors, hence cannot build argtable3. Besides, these old versions cannot enforce standard compliance properly. In this patch, we enhance the CMakeList.txt script so we don't treat warnings as errors in very old gcc versions.
tomghuang
force-pushed
the
fix-strtol0x-param-width-warnings
branch
from
9e73146 to
cf5bee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with older compilers, such as Xcode's gcc 4.2, triggered "different width due to prototype" warnings.
This occurs because character literals (e.g., 'X') are promoted to
intwhen passed as function arguments, but thestrtol0Xfunction signature expected achar.This change corrects the function signature to accept an
int, which resolves the compiler warnings and improves portability.