Open
Conversation
test: split with approvals+delegations
LCOV of commit
|
…sfers test: split merge delegations transfers
test: partial transfers with approve-split-merge-vote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated contract scans revealed 2 areas of the EscrowIVotesAdapter that, if misconfigured, could lead to incorrect state. This upgrade fixes the delegation checkpoint behaviour by overwriting delegation checkpoints, instead of appending them - preventing edge cases where binary search may return a stale value. It also removes approval-based delegation and undelegation flows, requiring that the msg.sender is always the owner of the tokenId, not an authorised caller. The latter path is not a useful feature in practice but could lead to incorrect state, so we have removed it. This set of transactions upgrades the contract without requiring a state change. No new state variables are introduced and no state variables are changed. Regression tests have been written to confirm this using OpenZeppelin Upgrades.