-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[batch-encryption] remove happy path in impls and traits #18445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+198
−572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
Draft
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
22 tasks
780a06d to
6136a74
Compare
6350e23 to
ac16a37
Compare
6136a74 to
f35eed1
Compare
JoshLind
approved these changes
Jan 14, 2026
f35eed1 to
4708b23
Compare
rex1fernando
approved these changes
Jan 14, 2026
4708b23 to
1c8d6b7
Compare
1c8d6b7 to
c367747
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
We are not going to implement the fast path, so this PR removes fast path from the implementation and traits. We can revisit this later if we need to introduce fast path again.