Skip to content

Conversation

@ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Jan 13, 2026

Description

We are not going to implement the fast path, so this PR removes fast path from the implementation and traits. We can revisit this later if we need to introduce fast path again.

Copy link
Contributor Author

ibalajiarun commented Jan 13, 2026

@ibalajiarun ibalajiarun changed the base branch from balaji/enc-pool-5-3 to graphite-base/18445 January 14, 2026 00:10
@ibalajiarun ibalajiarun changed the base branch from graphite-base/18445 to main January 14, 2026 00:10
@ibalajiarun ibalajiarun marked this pull request as ready for review January 14, 2026 00:13
@ibalajiarun ibalajiarun marked this pull request as draft January 14, 2026 00:17
@ibalajiarun ibalajiarun changed the title [batch-encryption] remove happy path in test setup [batch-encryption] remove happy path in impls and traits Jan 14, 2026
@ibalajiarun ibalajiarun marked this pull request as ready for review January 14, 2026 00:56
@ibalajiarun ibalajiarun enabled auto-merge (rebase) January 14, 2026 22:16
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7

Compatibility test results for a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7 (PR)
1. Check liveness of validators at old version: a3ff6eef75d8e0a24caea52de8522a4e28bd1873
compatibility::simple-validator-upgrade::liveness-check : committed: 12620.07 txn/s, latency: 2749.19 ms, (p50: 2900 ms, p70: 3000, p90: 3400 ms, p99: 3800 ms), latency samples: 415940
2. Upgrading first Validator to new version: c367747260e0d4a31dc388f71d191aee4c4b8de7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5771.34 txn/s, latency: 5861.66 ms, (p50: 6500 ms, p70: 6600, p90: 6700 ms, p99: 6800 ms), latency samples: 197800
3. Upgrading rest of first batch to new version: c367747260e0d4a31dc388f71d191aee4c4b8de7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5645.36 txn/s, latency: 6034.26 ms, (p50: 6700 ms, p70: 6800, p90: 6900 ms, p99: 7200 ms), latency samples: 195760
4. upgrading second batch to new version: c367747260e0d4a31dc388f71d191aee4c4b8de7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9583.43 txn/s, latency: 3422.07 ms, (p50: 3400 ms, p70: 3900, p90: 4700 ms, p99: 5000 ms), latency samples: 319300
5. check swarm health
Compatibility test for a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c367747260e0d4a31dc388f71d191aee4c4b8de7

two traffics test: inner traffic : committed: 13648.00 txn/s, latency: 2762.61 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5077060
two traffics test : committed: 100.01 txn/s, latency: 729.16 ms, (p50: 700 ms, p70: 800, p90: 800 ms, p99: 900 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.273, avg: 2.172", "ConsensusProposalToOrdered: max: 0.168, avg: 0.165", "ConsensusOrderedToCommit: max: 0.045, avg: 0.042", "ConsensusProposalToCommit: max: 0.213, avg: 0.208"]
Max non-epoch-change gap was: 3 rounds at version 42188 (avg 0.00) [limit 4], 3.29s no progress at version 42188 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.28s no progress at version 2379604 (avg 0.28s) [limit 16].
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7

Compatibility test results for a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7 (PR)
Upgrade the nodes to version: c367747260e0d4a31dc388f71d191aee4c4b8de7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1721.98 txn/s, submitted: 1727.39 txn/s, failed submission: 5.41 txn/s, expired: 5.41 txn/s, latency: 1957.36 ms, (p50: 1200 ms, p70: 1500, p90: 2000 ms, p99: 11500 ms), latency samples: 139982
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 787.94 txn/s, submitted: 790.24 txn/s, failed submission: 2.30 txn/s, expired: 2.30 txn/s, latency: 5304.63 ms, (p50: 1200 ms, p70: 10900, p90: 12100 ms, p99: 13000 ms), latency samples: 61760
5. check swarm health
Compatibility test for a3ff6eef75d8e0a24caea52de8522a4e28bd1873 ==> c367747260e0d4a31dc388f71d191aee4c4b8de7 passed
Upgrade the remaining nodes to version: c367747260e0d4a31dc388f71d191aee4c4b8de7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2385.84 txn/s, submitted: 2396.73 txn/s, failed submission: 10.89 txn/s, expired: 10.89 txn/s, latency: 1207.47 ms, (p50: 1200 ms, p70: 1200, p90: 1500 ms, p99: 2100 ms), latency samples: 214684
Test Ok

@ibalajiarun ibalajiarun merged commit def1598 into main Jan 15, 2026
60 of 61 checks passed
@ibalajiarun ibalajiarun deleted the balaji/enc-pool-5-4 branch January 15, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants