Refactor onchain config getters

[ibalajiarun]

Description

I asked cursor to refactor the onchain config impl to make it more readable.

[ibalajiarun]

• Refactor onchain config getters #18168 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✅ Forge suite compat success on d5cdd53bb8fe7ba6e16e7f74a174edd5f23083da ==> dc708def1ea35db2489fd1d3f5bf5647880d7088

Compatibility test results for d5cdd53bb8fe7ba6e16e7f74a174edd5f23083da ==> dc708def1ea35db2489fd1d3f5bf5647880d7088 (PR)
1. Check liveness of validators at old version: d5cdd53bb8fe7ba6e16e7f74a174edd5f23083da
compatibility::simple-validator-upgrade::liveness-check : committed: 13167.76 txn/s, latency: 2596.48 ms, (p50: 2700 ms, p70: 2900, p90: 3100 ms, p99: 3700 ms), latency samples: 435760
2. Upgrading first Validator to new version: dc708def1ea35db2489fd1d3f5bf5647880d7088
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4957.72 txn/s, latency: 6899.12 ms, (p50: 7700 ms, p70: 7800, p90: 7900 ms, p99: 8000 ms), latency samples: 176400
3. Upgrading rest of first batch to new version: dc708def1ea35db2489fd1d3f5bf5647880d7088
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4943.16 txn/s, latency: 6947.21 ms, (p50: 7700 ms, p70: 7800, p90: 7900 ms, p99: 7900 ms), latency samples: 175760
4. upgrading second batch to new version: dc708def1ea35db2489fd1d3f5bf5647880d7088
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7718.72 txn/s, latency: 4245.00 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5000 ms), latency samples: 273940
5. check swarm health
Compatibility test for d5cdd53bb8fe7ba6e16e7f74a174edd5f23083da ==> dc708def1ea35db2489fd1d3f5bf5647880d7088 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on dc708def1ea35db2489fd1d3f5bf5647880d7088

two traffics test: inner traffic : committed: 13445.96 txn/s, submitted: 13446.02 txn/s, expired: 0.05 txn/s, latency: 2798.15 ms, (p50: 2700 ms, p70: 2900, p90: 3100 ms, p99: 3600 ms), latency samples: 5006860
two traffics test : committed: 100.00 txn/s, latency: 853.61 ms, (p50: 800 ms, p70: 900, p90: 900 ms, p99: 2900 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.272, avg: 2.128", "ConsensusProposalToOrdered: max: 0.170, avg: 0.167", "ConsensusOrderedToCommit: max: 0.091, avg: 0.072", "ConsensusProposalToCommit: max: 0.256, avg: 0.239"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.54s no progress at version 5245182 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.26s no progress at version 2430475 (avg 0.26s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[danielxiangzl]

lgtm. How is this change test?

[danielxiangzl]

nit: there is no V6

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.