add: add an exception handler feature for Discord #37

Colk-tech · 2026-01-04T08:45:04Z

No description provided.

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

Copilot

Pull request overview

This PR adds an exception handler feature for Discord along with a complete nickname change tracking system. The implementation includes a Discord bot that monitors member nickname changes, records them to a database, and provides error notification capabilities through Discord embeds with Sentry and Logfire integration.

Key Changes:

Discord bot implementation with nickname change monitoring and error handling via embeds
Complete nickname changelog tracking system with usecase, repositories, and domain models
Database migrations for messenger, user, and nickname_changelog tables with seed data for Discord

Reviewed changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/system/ui/discord/bot.py	Discord bot implementation with on_member_update handler and error notification channel management
src/system/ui/discord/error_handler.py	Error embed sender with Sentry and Logfire trace ID integration
src/system/ui/discord/config.py	Added ERROR_NOTIFICATION_CHANNEL_ID configuration property
src/system/usecase/nickname/record_nickname_change.py	Usecase for recording nickname changes with messenger/user/changelog repository orchestration
src/system/usecase/nickname/dto.py	Request/response DTOs for nickname change recording
src/system/usecase/nickname/interface.py	Usecase interface definition
src/system/infrastructure/repository/sqlalchemy/crud/messenger.py	Added get_by_name method for messenger lookup and @Inject decorator
src/system/infrastructure/repository/sqlalchemy/crud/user.py	Added @Inject decorator
src/system/infrastructure/repository/sqlalchemy/crud/nickname.py	Added @Inject decorator
src/system/domain/interface/repository/messenger.py	Added get_by_name method to interface
src/system/infrastructure/ext/logfire/trace.py	Utility for extracting OpenTelemetry trace IDs
src/system/di/module/usecase/nickname/module.py	Dependency injection module for nickname usecase
src/system/di/module/ui/discord/bot/module.py	Dependency injection module for Discord bot
src/system/di/container.py	Integrated nickname usecase and Discord bot modules
migration/versions/87e1bd665ac8_create_initial_tables.py	Creates messenger, user, and nickname_changelog tables
migration/versions/b59d27038977_seed_discord_messenger.py	Seeds Discord messenger entry with fixed ULID
migration/env.py	Enhanced URL replacement to handle postgresql+asyncpg:// URLs
config.py	Added error_notification_channel_id configuration field
env/test.env	Added ERROR_NOTIFICATION_CHANNEL_ID environment variable
pyproject.toml	Added greenlet dependency
src/system/ui/discord/test_bot.py	Comprehensive tests for Discord bot functionality
src/system/ui/discord/test_error_handler.py	Tests for error embed sending
src/system/usecase/nickname/test_record_nickname_change.py	Tests for nickname change recording usecase
src/system/usecase/nickname/test_dto.py	Tests for DTOs
src/system/usecase/nickname/test_interface.py	Tests for interface
src/system/infrastructure/repository/sqlalchemy/crud/test_messenger.py	Tests for get_by_name method
src/system/infrastructure/ext/logfire/test_trace.py	Tests for trace ID extraction
src/system/di/module/usecase/nickname/test_nickname_usecase_module.py	Tests for DI module
src/system/di/module/ui/discord/bot/test_discord_bot_module.py	Tests for Discord bot DI module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-04T08:50:00Z

migration/env.py

+    if database_url and "asyncpg" in database_url:
+        database_url = database_url.replace("postgresql+asyncpg://", "postgresql://")
        database_url = database_url.replace("asyncpg://", "postgresql://")


The URL replacement logic has redundancy. Line 73 already handles the "postgresql+asyncpg://" prefix replacement, making line 74's "asyncpg://" replacement unnecessary since the condition on line 72 checks for "asyncpg" in the URL. Consider removing line 74 or refactoring this logic to be clearer about which URL formats are supported.

Suggested change

if database_url and "asyncpg" in database_url:

database_url = database_url.replace("postgresql+asyncpg://", "postgresql://")

database_url = database_url.replace("asyncpg://", "postgresql://")

if database_url:

if database_url.startswith("postgresql+asyncpg://"):

database_url = database_url.replace("postgresql+asyncpg://", "postgresql://", 1)

elif database_url.startswith("asyncpg://"):

database_url = database_url.replace("asyncpg://", "postgresql://", 1)

Copilot · 2026-01-04T08:50:01Z

migration/versions/b59d27038977_seed_discord_messenger.py

+# 固定 ULID（再実行可能にするため、26文字）
+# ULID は 0123456789ABCDEFGHJKMNPQRSTVWXYZ のみ使用可能


Comments in the codebase should be in English for consistency and accessibility. The Japanese comments on lines 21-22 and 51-52 should be translated to English.

Suggested change

# 固定 ULID（再実行可能にするため、26文字）

# ULID は 0123456789ABCDEFGHJKMNPQRSTVWXYZ のみ使用可能

# Fixed ULID (26 characters so that the migration can be re-run deterministically)

# ULID may only use the characters 0123456789ABCDEFGHJKMNPQRSTVWXYZ

Copilot · 2026-01-04T08:50:01Z

src/system/usecase/nickname/record_nickname_change.py

+    ) -> RecordNicknameChangeResponse:
+        now = utcnow()
+
+        # メッセンジャーを取得


Comments in the codebase should be in English for consistency and accessibility. The Japanese comments should be translated to English.

Copilot · 2026-01-04T08:50:01Z

src/system/usecase/nickname/record_nickname_change.py

+
+        messenger = messenger_response.response
+
+        # ユーザーを取得または作成


Comments in the codebase should be in English for consistency and accessibility. The Japanese comments should be translated to English.

Copilot · 2026-01-04T08:50:01Z

src/system/usecase/nickname/record_nickname_change.py

+
+        existing_user = user_response.response
+
+        # ニックネーム変更履歴を作成


Comments in the codebase should be in English for consistency and accessibility. The Japanese comments should be translated to English.

Colk-tech and others added 10 commits January 4, 2026 17:24

add: add get_current_trace_id()

34704f8

add: add get_current_trace_id() and tests for it

f8070c9

add: add ERROR_NOTIFICATION_CHANNEL_ID in DiscordConfigIf

4c2fef0

add: add ERROR_NOTIFICATION_CHANNEL_ID in BaseConfig

fe3cc2c

remove: remove no longer required .gitkeep

11f9ebc

add: add send_error_embed() and tests for it

e164f2f

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

add: add ERROR_NOTIFICATION_CHANNEL_ID in test.env

2e60d95

add: add exception handler with error notification in DiscordBot

2726981

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

add: add !exception-test command for debugging error notifications

df0cf73

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

add: add error thumbnail image to error embed

1b5128b

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

Colk-tech self-assigned this Jan 4, 2026

Copilot AI review requested due to automatic review settings January 4, 2026 08:45

Colk-tech added the enhancement New feature or request label Jan 4, 2026

Copilot started reviewing on behalf of Colk-tech January 4, 2026 08:45 View session

Copilot AI reviewed Jan 4, 2026

View reviewed changes

Merge branch 'main' into add-exception-handler

de12c9d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add: add an exception handler feature for Discord #37

add: add an exception handler feature for Discord #37

Uh oh!

Colk-tech commented Jan 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    if database_url and "asyncpg" in database_url:
-        database_url = database_url.replace("postgresql+asyncpg://", "postgresql://")
-        database_url = database_url.replace("asyncpg://", "postgresql://")
+    if database_url:
+        if database_url.startswith("postgresql+asyncpg://"):
+            database_url = database_url.replace("postgresql+asyncpg://", "postgresql://", 1)
+        elif database_url.startswith("asyncpg://"):
+            database_url = database_url.replace("asyncpg://", "postgresql://", 1)

		# 固定 ULID（再実行可能にするため、26文字）
		# ULID は 0123456789ABCDEFGHJKMNPQRSTVWXYZ のみ使用可能


		messenger = messenger_response.response

		# ユーザーを取得または作成


		existing_user = user_response.response

		# ニックネーム変更履歴を作成

Uh oh!

add: add an exception handler feature for Discord #37

Are you sure you want to change the base?

add: add an exception handler feature for Discord #37

Uh oh!

Conversation

Colk-tech commented Jan 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants