📝 LICENSE.txt documentation #7
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances the LICENSE.txt file and adds extensive documentation about licensing, commercial support, and maintainer support in the README. The changes add the maintainer's name to the copyright notice and introduce a detailed explanation of an ethical dual-licensing model while maintaining the MIT License as the legal framework.
Changes:
- Updated copyright notice in LICENSE.txt to include the maintainer's name
- Added detailed licensing documentation explaining the MIT License and optional commercial support model
- Enhanced the ore tool description with attribution to its creator
- Added comprehensive sections on paid licensing, donation requests, and sponsorship information
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| LICENSE.txt | Added maintainer name (Peter H. Boling) to the copyright notice |
| README.md | Extensively expanded the License section with dual-licensing information, added paid license details, included sponsorship/donation information, and enhanced tool attribution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The [MIT License][📄license-ref] covers this software. | ||
|
|
||
| See [LICENSE](LICENSE.txt) for details, but note the following: | ||
|
|
||
| 1. The terms of the MIT License let you use and share this software for all purposes, commercial, and non-commercial, for free. | ||
| 2. However, the MIT License allows selling copies of the software for a fee, and I have chosen to do this for [big businesses](#big-business), as an ethical matter, not a legal matter. | ||
| 3. Paid (optional) licenses for [big businesses](#big-business) are available on fair, reasonable, and nondiscriminatory terms. | ||
| 4. So, anyone can use the software for free in _any_ and _all_ cases... But to quote the MIT License itself, | ||
|
|
||
| > Permission is hereby granted, free of charge, to any person ..., to deal | ||
| > in the Software without restriction, including without limitation the rights | ||
| > to ... sell copies of the Software | ||
|
|
||
| Open source will die without commercial support, so I am letting you know when and what **you should pay** | ||
| as an ethical matter, not as a legal matter. |
There was a problem hiding this comment.
The documentation introduces a dual-licensing model that may confuse users. While the text states the software is covered by the MIT License and repeatedly says "as an ethical matter, not a legal matter," the extensive details about paid licenses, commercial terms, and specific dollar amounts may create confusion about the actual legal terms. Consider adding a clearer disclaimer at the beginning of the License section that explicitly states the MIT License is the only legal license and all subsequent text is purely voluntary guidance.
| ### ore | ||
|
|
||
| [ore](https://github.com/contriboss/ore-light) is a fast gem installer written in Go. It's Bundler-compatible but performs downloads significantly faster using Go's concurrency features. Use `bundle exec` to run gem commands after ore installs your gems. | ||
| [ore](https://github.com/contriboss/ore-light) is a fast gem installer written in Go. It's Bundler-compatible but performs downloads significantly faster using Go's concurrency features. Use `bundle exec` to run gem commands after ore installs your gems. Created by [@seuros](https://github.com/seuros), a long time Rubyist, and prolific [writer](https://www.seuros.com/blog/rubygems-coup-when-parasites-take-the-host/). |
There was a problem hiding this comment.
When "long time" is used as a compound modifier before a noun, it should be hyphenated as "long-time".
| [ore](https://github.com/contriboss/ore-light) is a fast gem installer written in Go. It's Bundler-compatible but performs downloads significantly faster using Go's concurrency features. Use `bundle exec` to run gem commands after ore installs your gems. Created by [@seuros](https://github.com/seuros), a long time Rubyist, and prolific [writer](https://www.seuros.com/blog/rubygems-coup-when-parasites-take-the-host/). | |
| [ore](https://github.com/contriboss/ore-light) is a fast gem installer written in Go. It's Bundler-compatible but performs downloads significantly faster using Go's concurrency features. Use `bundle exec` to run gem commands after ore installs your gems. Created by [@seuros](https://github.com/seuros), a long-time Rubyist, and prolific [writer](https://www.seuros.com/blog/rubygems-coup-when-parasites-take-the-host/). |
|
|
||
| To say "thanks!" ☝️ Join the Discord or 👇️ send money. | ||
|
|
||
| [![Sponsor appraisal-rb/ast-merge on Open Source Collective][🖇osc-all-bottom-img]][🖇osc] 💌 [![Sponsor me on GitHub Sponsors][🖇sponsor-bottom-img]][🖇sponsor] 💌 [![Sponsor me on Liberapay][⛳liberapay-bottom-img]][⛳liberapay] 💌 [![Donate on PayPal][🖇paypal-bottom-img]][🖇paypal] |
There was a problem hiding this comment.
The badge text references "appraisal-rb/ast-merge" but this appears to be incorrect. Based on the repository context, it should reference "appraisal-rb/setup-ruby-flash" or potentially just "appraisal-rb" if referring to the organization's collective.
| [![Sponsor appraisal-rb/ast-merge on Open Source Collective][🖇osc-all-bottom-img]][🖇osc] 💌 [![Sponsor me on GitHub Sponsors][🖇sponsor-bottom-img]][🖇sponsor] 💌 [![Sponsor me on Liberapay][⛳liberapay-bottom-img]][⛳liberapay] 💌 [![Donate on PayPal][🖇paypal-bottom-img]][🖇paypal] | |
| [![Sponsor appraisal-rb on Open Source Collective][🖇osc-all-bottom-img]][🖇osc] 💌 [![Sponsor me on GitHub Sponsors][🖇sponsor-bottom-img]][🖇sponsor] 💌 [![Sponsor me on Liberapay][⛳liberapay-bottom-img]][⛳liberapay] 💌 [![Donate on PayPal][🖇paypal-bottom-img]][🖇paypal] |
No description provided.