[SLG-0004]: Revised Metadata value attributes + sensitivity attribute proposal#440
Open
kukushechkin wants to merge 1 commit intoapple:mainfrom
Open
[SLG-0004]: Revised Metadata value attributes + sensitivity attribute proposal#440kukushechkin wants to merge 1 commit intoapple:mainfrom
kukushechkin wants to merge 1 commit intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is a revision of SLG-0004 previously discussed here.
Add an extensible per-value attribute mechanism for metadata, with sensitivity as the first attribute.
Motivation:
Metadata values in
swift-logare opaque strings by the time theLogHandlerreceives them. The call site oftenknows things about a value that the handler cannot infer — for example, whether the value should be redacted in
different environments.
Modifications:
Result:
Revised SLG-0004 proposal is ready for review.