[WIP] Logging, auditing, warnings, and PingContext failure handling for switch DB#77
Open
ninabauer wants to merge 3 commits intoapp-sre:mainfrom
Open
[WIP] Logging, auditing, warnings, and PingContext failure handling for switch DB#77ninabauer wants to merge 3 commits intoapp-sre:mainfrom
ninabauer wants to merge 3 commits intoapp-sre:mainfrom
Conversation
Contributor
ninabauer
commented
Aug 7, 2024
ninabauer
commented
- adds log output when switching db name
- adds dbname in audit data
- after OverrideDBName, try a DB.PingContext, if it fails, fall back to its last value.
- when current db name is different with env DB_NAME, returns a warning saying current db is not the default one in the response json
BumbleFeng
reviewed
Aug 30, 2024
| Result [][]string `json:"result"` | ||
| Error string `json:"error"` | ||
| Result [][]string `json:"result"` | ||
| Warnings []string `json:"warnings,omitempty"` |
Contributor
There was a problem hiding this comment.
Is there any particular reason to set Warnings as an array？ It is a bit weird to have Error as string but Warning as Array.
| response := models.DBNameResponse{DBName: dbName} | ||
|
|
||
| if dbName != defaultDBName { | ||
| warning := "Current database differs from the default" |
Contributor
There was a problem hiding this comment.
Could you add dbName and defaultDBName info to the warn msg?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.