APPSRE-12149: Stream query rows to client rather than storing#100
Open
PaulWay wants to merge 2 commits intoapp-sre:mainfrom
Open
APPSRE-12149: Stream query rows to client rather than storing#100PaulWay wants to merge 2 commits intoapp-sre:mainfrom
PaulWay wants to merge 2 commits intoapp-sre:mainfrom
Conversation
Signed-off-by: Paul Wayper <paulway@redhat.com>
|
Can one of the admins verify this patch? |
Author
|
This PR was written with assistance from the qwen2.5-coder-14b-instruct LLM. Code was not copied directly from the LLM. A local model was used so no code was shared externally. |
Contributor
|
[test] |
Signed-off-by: Paul Wayper <paulway@redhat.com>
Contributor
|
/ok-to-test |
Author
|
I was asked to raise https://issues.redhat.com/browse/APPSRE-12149 after no-one in AppSRE had looked at this ticket. |
PaulWay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GABI has to store the entire (stringified) result list before sending it to the client. With very large queries, this can cause timeouts or death by OOM. This change sends each record to the HTTP client as it's received from the database, reducing overall memory use and speeding up responses.