This repository was archived by the owner on Apr 13, 2023. It is now read-only.
fix: add check for resetQueryStoreErrors in afterExecute#3599
Open
shomukai wants to merge 2 commits intoapollographql:masterfrom
Open
fix: add check for resetQueryStoreErrors in afterExecute#3599shomukai wants to merge 2 commits intoapollographql:masterfrom
shomukai wants to merge 2 commits intoapollographql:masterfrom
Conversation
|
@shomukai: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for resetQueryStoreErrors.
The resetQueryStoreErrors function is in query's prototype, in theory it should not be undefined. But we encountered a case where resetQueryStoreErrors is undefined after some network error.
So got an error like:
Still chasing what caused it.
As a quick fix, just added a check for resetQueryStoreErrors.
Please close this pull request, if not related.
Thanks.
And thanks for your time in advance.
We are using these versions:
@apollo/react-hooks 3.1.1
apollo-client 2.6.4
react-apollo 3.1.1
apollo-link 1.2.13
apollo-link-http 1.5.16
apollo-link-http-common 0.2.15
apollo-link-retry 2.2.15
apollo-utilities 1.3.2
Checklist: