-
-
Notifications
You must be signed in to change notification settings - Fork 199
chore: remove deprecated API and unused action #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe update replaces deprecated file and response reading functions with their modern counterparts. The Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。 |
2951c8e to
a5fbe99
Compare
|
@nobodyiam PTAL. |
Pull Request Test Coverage Report for Build 14312814009Details
💛 - Coveralls |
|
@xuthus5 Could you share your reasons for upgrading the Go toolchain to 1.18? |
|
|
这次升级看上去是和之前版本不兼容的是吗? |
|
这个 PR 发生了冲突. @xuthus5 是否能帮忙修复呢? 🙏 |
是的,如果变更该代码仓go版本号为1.15,则用户1.14版本的项目无法使用最新发布的版本,也就是会使依赖该项目但是项目版本号低于当前代码仓go.mod中定义的版本号的项目,无法使用新的发布版本。 基于你的目标分支修改,我了解前面已经有人在develop分支将go版本号升级到1.20。 该次修改移除被弃用API与过时的action任务。 |
Signed-off-by: Young Xu <xuthus5@gmail.com>
Key changes:
ioutilBREAKING CHANGE: Development environments must upgrade to Go 1.18+
Summary by CodeRabbit
Refactor
Chores
go.modfile.