Fix performance regression with limit on unordered queries#90
Merged
j6k4m8 merged 1 commit intoaplbrain:masterfrom Nov 13, 2025
Merged
Fix performance regression with limit on unordered queries#90j6k4m8 merged 1 commit intoaplbrain:masterfrom
j6k4m8 merged 1 commit intoaplbrain:masterfrom
Conversation
CodSpeed Performance ReportMerging #90 will improve performances by ×3.8Comparing Summary
Benchmarks breakdown
|
Member
|
this is awesome — good to merge in?? thanks for chasing down the extra merge confs :) |
Member
|
ahh that's a great catch on the digraphs... we should hit that in a test, @khoale88 |
Contributor
Author
|
I think this is good to merge in. @khoale88 might have a better way to work around the DiGraph issue I was encountering, could be a deeper issue there. |
Member
|
Super, thank you @davidmezzetti !! This is a snazzy performance bump :) |
Contributor
|
Please create an issue so we dont forget about it. |
Contributor
Author
I added #91 to let you take a look and determine if further action is needed. |
Member
|
Thank you @davidmezzetti — really appreciate this fix + bug report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting PR (same as #87) with recent changes merged in.
I also had to make another change due to a separate error that came up with the latest commit. It looks like the new
auto_node_jsondata_hintsfeature assumes the graph is a DiGraph. Having that enabled was raising an error from grandiso saying host has no attributepred. Without this change, I was receiving the following stacktrace.