-
Notifications
You must be signed in to change notification settings - Fork 15
Support _auto_node_jsondata_hint feature and _node_indexer. #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
khoale88
commented
Nov 2, 2025
- auto generate a hint from node json data.
- use node indexer for hint generator when indexing available.
9951063 to
ae42c6a
Compare
|
still reading through this but I love it so far! want to be sure I fully understand Indexers before merging, they seem like an amazing opportunity for some performance improvements to this codebase :) |
|
Sorry for the lack of documentation. Instead of complex Btree support fastter write, ArrayIndexer will have everything sorted in ascending order, and any searching would be logN. However, it hasn't deal with None value for now. |
|
I will handle null value with indexter in the #69 |
65e6b33 to
a9a7178
Compare
|
@j6k4m8 I rebase this to the subquery PR, so you see there're a lot. But if you merge the PR and rebase this once more, change will be small. I changed the implementation a little bit. I don't compute the node hints before hand. Instead, When the match happens, I convert the motif to indexer condition ast and then AND it with the where ast. This is much cleaner. I also enable node auto hint by default. I think it's worth to do 3 other indexing feature to complete this one.
|
- check if node and edge from hints are valid matches
…). - auto generate a hint from node json data. - use node indexer for hint generator when indexing available.
|
Once the benchmarks finish, can I merge this in? :) |
|
Yes, please. |
|
Hooray! :D |