Changed the requirements to also work on Mac OS (CPU only)#23
Open
kristof wants to merge 1 commit intoapirrone:mainfrom
Open
Changed the requirements to also work on Mac OS (CPU only)#23kristof wants to merge 1 commit intoapirrone:mainfrom
kristof wants to merge 1 commit intoapirrone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform-Specific Dependency Marker
This line uses a PEP 508 environment marker (
sys_platform == 'linux'). This conditional dependency means:jax>=0.5.0ANDjax[cuda12]>=0.5.0are installed (the latter brings in CUDA 12 GPU support)jax>=0.5.0(line 9) is installed — the CUDA extra is skipped entirelyThis is critical because:
jax[cuda12]on Mac, which would fail due to missing CUDA librariesSummary
The setup is smart: it provides GPU acceleration on Linux via CUDA while gracefully falling back to CPU-only (or Metal) execution on Mac. The
sys_platform == 'linux'marker is what makes this "just work" across platforms without requiring separate requirement files.