refactor: Remove internal models module in favor of generated models#649
Closed
refactor: Remove internal models module in favor of generated models#649
Conversation
ActorJob and ActorJobResponse schemas were added to the OpenAPI spec (apify/apify-docs#XXXX), so they are now generated into _models.py. This removes the manually maintained _internal_models.py module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 96.62% 96.70% +0.08%
==========================================
Files 45 45
Lines 4271 4375 +104
==========================================
+ Hits 4127 4231 +104
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_internal_models.pymodule —ActorJobandActorJobResponseare now generated from the OpenAPI spec_models.pyfrom updated spec that includes the new schemas_resource_client.pyfrom_internal_modelsto_modelsRelated
Test plan
_wait_for_finish) works correctly with generated models🤖 Generated with Claude Code