[WebGPU] Reserve additional keywords to avoid WGSL identifier collisions#18960
Open
akaashrp wants to merge 1 commit intoapache:mainfrom
Open
[WebGPU] Reserve additional keywords to avoid WGSL identifier collisions#18960akaashrp wants to merge 1 commit intoapache:mainfrom
akaashrp wants to merge 1 commit intoapache:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the WebGPU code generator by reserving several WGSL keywords and access modes, such as "storage" and "read_write", to prevent name collisions during code generation. The reviewer suggests expanding this list to include a more comprehensive set of WGSL identifiers, including basic types and fundamental keywords like "fn" and "struct", to ensure greater robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling Qwen3.5 yielded WGSL of the following form:
var<storage, read_write> storage : array<f32>;. This led to a 'cyclic dependency' error due to the identifier collision. This PR reserves keywords such as storage to avoid parsing errors.