Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Jan 11, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CMake build system by introducing a dedicated option to manage the dependency on the Threads library. This provides greater flexibility for users to explicitly enable or disable threading support during the build process, which can be beneficial for specific deployment scenarios or environments where threading is not required or causes conflicts.

Highlights

  • New CMake Option for Threading Control: Introduced the TVM_FFI_USE_THREADS CMake option, defaulting to ON, to explicitly control whether the tvm_ffi library links against the Threads library.
  • Conditional Thread Linking: The tvm_ffi target now conditionally links Threads::Threads based on the state of the new TVM_FFI_USE_THREADS option.
  • Required Thread Package: When TVM_FFI_USE_THREADS is enabled, find_package(Threads REQUIRED) is used, making the Threads package a mandatory dependency for the build to succeed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new CMake option, TVM_FFI_USE_THREADS, to explicitly control linking against the threads library. This change improves the build system's configurability by making the dependency on threads optional and explicit. When the option is enabled, the build will now correctly fail if the threads library is not found, which is a clearer behavior than the previous implementation. The change is well-implemented, though I've noted a minor typo in the new option's description.

# be found but downstream may still be able to build extra alternatives via source bundle
if (TVM_FFI_USE_THREADS)
find_package(Threads REQUIRED)
target_link_libraries(tvm_ffi_shared PRIVATE Threads::Threads)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent this line

@junrushao junrushao merged commit 3b4a532 into apache:main Jan 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants