modified atomic::ordering about SHOULD_CAPTURE #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

wang384670111 wants to merge 1 commit into apache:master from wang384670111:modified_ordering

wang384670111 commented Mar 31, 2023 •

edited

Loading

https://github.com/apache/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L261
https://github.com/apache/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L287
I think the use of ordering here is irregular, SHOULD_CAPYURE is used not to synchronize access to other shared variables. I think just Ordering::Relaxed needs to be used here to ensure the correctness of the program.


          modified atomic::ordering about SHOULD_CAPTURE

e8fdbf3

Contributor

volcano0dr commented Apr 6, 2023

@wang384670111 Thanks for reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet