Skip to content

fixed finished job is no need alert. #4293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mrart wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed finished job is no need alert. #4293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...service/src/main/java/org/apache/streampark/console/core/watcher/FlinkAppHttpWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,6 @@ private void handleNotRunState(
doPersistMetrics(application, false);
break;
case CANCELED:
case FINISHED:
log.info(
"[StreamPark][FlinkAppHttpWatcher] getFromFlinkRestApi, job state {}, stop tracking and delete stopFrom!",
currentState.name());
Expand All @@ -504,6 +503,26 @@ private void handleNotRunState(
doPersistMetrics(application, true);
cleanOptioning(optionState, application.getId());
break;
case FINISHED:
log.info(
"[StreamPark][FlinkAppHttpWatcher] getFromFlinkRestApi, job state {}, stop tracking and delete stopFrom!",
currentState.name());
cleanSavepoint(application);
application.setState(currentState.getValue());
if (StopFromEnum.NONE.equals(stopFrom) || applicationInfoService.checkAlter(application)) {
if (StopFromEnum.NONE.equals(stopFrom)) {
log.info(
"[StreamPark][FlinkAppHttpWatcher] getFromFlinkRestApi, job finished is not form StreamPark,savepoint expired!");
savepointService.expire(application.getId());
}
stopCanceledJob(application.getId());
// 不发送报警，因为FINISHED对于批作业是正常状态
Copy link
Member

@wolfboys wolfboys Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment i18n minor issues need to be fixed.

// doAlert(application, FlinkAppStateEnum.CANCELED);
Copy link
Contributor

@RocMarshal RocMarshal Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What about dropping the commented line if we not need it ?
  • For the current patch, We'd better to follow [1] to create an issue for tracking the change of the current PR.
  • ditto to the title of the PR and commit message.

[1] https://streampark.apache.org/community/submit_guide/code_style_and_quality_guide#1-pull-requests--changes-rule

}
STOP_FROM_MAP.remove(application.getId());
doPersistMetrics(application, true);
cleanOptioning(optionState, application.getId());
break;
case FAILED:
cleanSavepoint(application);
STOP_FROM_MAP.remove(application.getId());
Expand Down