Skip to content

Conversation

@CuteShaos
Copy link
Contributor

Enable variable support for saving point paths and resolve the bug in version 2.1.6 where getFinalSavepointDir did not receive a processPath return value, resulting in redundant calls and logical errors

What changes were proposed in this pull request

Issue Number: close #4278

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

@wolfboys wolfboys requested a review from Copilot September 1, 2025 08:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables variable support for Flink savepoint paths and fixes a bug where the getFinalSavepointDir method did not receive the processed path return value in version 2.1.6.

  • Adds variable substitution support for job names and IDs in savepoint paths
  • Restructures the savepoint path resolution logic to ensure proper processing order
  • Introduces a new processPath method to handle variable replacement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor Author

@CuteShaos CuteShaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matching result of the two writing styles is the same. The modification avoids useless captures and is more recommended.
The parameters jobName and jobId are not null

@CuteShaos CuteShaos closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors

1 participant