[SPARK-55453][SQL] Fix LIKE pattern matching for supplementary Unicode characters#54665
Open
xiaoxuandev wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-55453][SQL] Fix LIKE pattern matching for supplementary Unicode characters#54665xiaoxuandev wants to merge 1 commit intoapache:masterfrom
xiaoxuandev wants to merge 1 commit intoapache:masterfrom
Conversation
…e characters (e.g. emojis) Fix escapeLikeRegex and LikeSimplification to correctly handle supplementary Unicode characters (code points above U+FFFF, e.g. emojis), which are stored as surrogate pairs in Java's UTF-16 String representation. Two bugs when LIKE patterns contain supplementary characters: 1. escapeLikeRegex iterated by Char (UTF-16 code unit), splitting surrogate pairs into two separate regex quotations. Fixed by iterating with codePoints(). 2. LikeSimplification used String.length (UTF-16 code unit count) for the Length guard, but Spark's Length() returns code point count. Fixed by using codePointCount(). Yes. LIKE patterns with emojis and other supplementary characters now match correctly. Added tests in StringUtilsSuite, RegexpExpressionsSuite, and LikeSimplificationSuite. Verified test fails without the fix. Build and scalastyle pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix escapeLikeRegex and LikeSimplification to correctly handle supplementary Unicode characters (code points above U+FFFF, e.g. emojis), which are stored as surrogate pairs in Java's UTF-16 String representation.
Why are the changes needed?
Two bugs when LIKE patterns contain supplementary characters:
escapeLikeRegex iterated by Char (UTF-16 code unit), splitting surrogate pairs into two separate regex quotations. Fixed by iterating with codePoints().
LikeSimplification used String.length (UTF-16 code unit count) for the Length guard, but Spark's Length() returns code point count. Fixed by using codePointCount().
Does this PR introduce any user-facing change?
Yes. LIKE patterns with emojis and other supplementary characters now match correctly.
How was this patch tested?
Added tests in StringUtilsSuite, RegexpExpressionsSuite, and LikeSimplificationSuite. Verified test fails without the fix. Build and scalastyle pass.