[SPARK-55289][SQL][FOLLOWUP] Fix flaky test in-order-by.sql by disabling broadcast join#54663
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55289][SQL][FOLLOWUP] Fix flaky test in-order-by.sql by disabling broadcast join#54663yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn wants to merge 1 commit intoapache:masterfrom
Conversation
…ing broadcast join Same fix as SPARK-55289 for in-set-operations.sql. Adds `--SET spark.sql.autoBroadcastJoinThreshold=-1` to in-order-by.sql to prevent OOM from BroadcastHashJoin accumulating hash tables on memory-constrained CI runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dongjoon-hyun
approved these changes
Mar 7, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Same fix as #54072 (SPARK-55289) for
in-set-operations.sql. Adds--SET spark.sql.autoBroadcastJoinThreshold=-1toin-order-by.sqlto prevent OOM from BroadcastHashJoin accumulating hash tables on memory-constrained CI runners.Why are the changes needed?
in-order-by.sqlintermittently fails on CI withSparkOutOfMemoryErrorfor the same root cause asin-set-operations.sql— complex correlated IN-subqueries with multiple BroadcastHashJoin operations exceeding JVM heap under memory pressure.Does this PR introduce any user-facing change?
No. Test-only change.
How was this patch tested?
Golden files regenerated. Minor row reordering for rows with identical sort keys (expected when switching from BroadcastHashJoin to SortMergeJoin).
Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with GitHub Copilot.