[SPARK-55275] Add InvalidPlanInput sql states for sql/connect#54652
Open
garlandz-db wants to merge 3 commits intoapache:masterfrom
Open
[SPARK-55275] Add InvalidPlanInput sql states for sql/connect#54652garlandz-db wants to merge 3 commits intoapache:masterfrom
garlandz-db wants to merge 3 commits intoapache:masterfrom
Conversation
garlandz-db
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add error class
SPARK_CONNECT_INVALID_PLAN_INPUTwith 65subclasses, covering all
InvalidPlanInputthrow sites across the Spark Connect layer (InvalidInputErrors,DataTypeProtoConverter,LiteralValueProtoConverter,SparkConnectAnalyzeHandler,SessionHolder,SparkConnectPlanner).Why are the changes needed?
InvalidPlanInputexceptions previously defaulted toINTERNAL_ERROR(SQL stateXX000), making plan-input validationfailures indistinguishable from genuine internal errors. Follows the pattern of #54056 which added
XXSC0forIllegalStateException.Does this PR introduce any user-facing change?
Yes.
InvalidPlanInputexceptions now carry SQL stateXXSC1and structured error conditions(
SPARK_CONNECT_INVALID_PLAN_INPUT.<SUBCLASS>) instead ofINTERNAL_ERROR/XX000.How was this patch tested?
Updated
InvalidInputErrorsSuiteto assert new error conditions andgetSqlState() == "XXSC1". All 5 tests pass.IllegalStateErrorsSuite(17 tests) unchanged and passing.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6