[SPARK-55831][FOLLOWUP] Fix Maven CI by replacing with dummy SPARK_HOME in test#54651
Open
pan3793 wants to merge 6 commits intoapache:masterfrom
Open
[SPARK-55831][FOLLOWUP] Fix Maven CI by replacing with dummy SPARK_HOME in test#54651pan3793 wants to merge 6 commits intoapache:masterfrom
pan3793 wants to merge 6 commits intoapache:masterfrom
Conversation
LuciferYang
reviewed
Mar 6, 2026
.github/workflows/maven_test.yml
Outdated
| ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pjvm-profiler -Pspark-ganglia-lgpl -Pkinesis-asl -Djava.version=${JAVA_VERSION/-ea} clean install | ||
| if [ "$MODULES_TO_TEST" != "connect" ]; then | ||
| if [ "$MODULES_TO_TEST" != *"hive-thriftserver"* ]; then |
Contributor
There was a problem hiding this comment.
I think we still need to implement more fine-grained control. Some modules have their test sequences prior to the assembly module, and we should ensure that these tests can be conducted without relying on assembly. At the least, we should have a mechanism to inspect, skip, and notify that enabling these tests requires assembly(such as assume).
Member
Author
There was a problem hiding this comment.
I switched to a simple approach that makes the test not depend on the assembly package, so we don't need to worry about this case.
…r yarn module" This reverts commit 95365a8.
Member
Author
This reverts commit 51c3096.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create a dummy SPARK_HOME for test, so that the YARN test won't depend on
assemblypackage.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass both Maven and SBT CI.
Was this patch authored or co-authored using generative AI tooling?
No.