[SPARK-55666][PYTHON][TEST] Fix flaky connect tests due to non-deterministic row order#54460
Open
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Open
Conversation
Yicong-Huang
force-pushed
the
SPARK-55666/fix/test-join-ambiguous-cols-row-order
branch
from
c3e9c5b to
9706860
Compare
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Feb 25, 2026
Yicong-Huang
force-pushed
the
SPARK-55666/fix/test-join-ambiguous-cols-row-order
branch
from
9706860 to
c2480bf
Compare
Yicong-Huang
changed the title
Yicong-Huang
force-pushed
the
SPARK-55666/fix/test-join-ambiguous-cols-row-order
branch
from
c2480bf to
b069942
Compare
Yicong-Huang
force-pushed
the
SPARK-55666/fix/test-join-ambiguous-cols-row-order
branch
from
b069942 to
e7bc195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
assertDataFrameEqualintest_join_ambiguous_colsto avoid non-deterministic row order failures.Why are the changes needed?
Many tests use
assertEqual(cdf.collect(), sdf.collect())to compare results with bag semantic. Since bags do not guarantee row order, this can fail non-deterministically (flaky test).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test
Was this patch authored or co-authored using generative AI tooling?
No.