Synchronize webdefault.xml and web.xml with Jetty 12#4153
Open
dsmiley wants to merge 1 commit intoapache:mainfrom
Open
Synchronize webdefault.xml and web.xml with Jetty 12#4153dsmiley wants to merge 1 commit intoapache:mainfrom
dsmiley wants to merge 1 commit intoapache:mainfrom
Conversation
with Jetty 12
dsmiley
commented
Feb 21, 2026
Contributor
Author
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Also, I retained the default directory listing as false, even though OOTB Jetty it's true.
| xmlns="http://java.sun.com/xml/ns/javaee" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd" | ||
| metadata-complete="true" |
Contributor
Author
There was a problem hiding this comment.
the default is actually metadata-complete="false", albeit it doesn't matter since we are explicit in our web.xml.
| </servlet-mapping> | ||
|
|
||
|
|
||
| <!-- ==================================================================== --> |
Contributor
Author
There was a problem hiding this comment.
I removed this, even though it's in the base/template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed our web.xml and webdefault.xml have become out of date, especially since they were not referring to jakarta.
For debdefault.xml, I copied the latest version and made some edits (see inline review). I reviewed the changelog of this file to see where we made intentional edits.
Not sure if needs a JIRA... not really aiming for a side-effect. Albeit it's nice to see a useless log message go away about JSP :-) No more: