Skip to content

SOLR-18099: CollapseQParser extensibility #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsmiley wants to merge 21 commits into
base: main
Choose a base branch
from
Open

SOLR-18099: CollapseQParser extensibility #4112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3b3a7b9
SOLR-18099: CollapsingQParserPlugin extensibility
dsmiley Feb 6, 2026
9856d84
some better documentation
dsmiley Feb 6, 2026
9e654f1
extract getDocValuesProducer
dsmiley Feb 6, 2026
76e890c
GroupHeadSelectorType is now a record
dsmiley Feb 6, 2026
2412a40
GroupHeadSelectorType.CUSTOM
dsmiley Feb 6, 2026
e066b19
refactor: GroupHeadSelector.needsScores
dsmiley Feb 11, 2026
0308398
getCollapsedDisi
dsmiley Feb 12, 2026
f448d8c
remove unused "values" param
dsmiley Feb 12, 2026
e3da939
NullPolicy: no getCode needed
dsmiley Feb 14, 2026
7a4829f
woops; fix
dsmiley Feb 14, 2026
b100160
Introduce AbstractCollapseCollector
dsmiley Feb 14, 2026
11b1f7a
setScorer harmonization
dsmiley Feb 14, 2026
1823e60
factor out a common complete()
dsmiley Feb 15, 2026
056b600
contexts is now a List not array
dsmiley Feb 15, 2026
4ef267c
refactors AbstractCollapseCollector.complete() into a template method…
dsmiley Feb 15, 2026
8ea6483
Defer needsScores detection until we have the delegate (then we know)…
dsmiley Feb 16, 2026
ea6c4ab
initCollapseValues() / initSegmentValues() helper methods
dsmiley Feb 16, 2026
1b1e0cd
Base collector: remove collectElevatedDocsWhenCollapsing (redundant)
dsmiley Feb 16, 2026
c98e5bf
Restore collapsedSet eager initialization
dsmiley Feb 16, 2026
ed3f675
Use DocIdSetBuilder instead of FixedBitSet (save memory).
dsmiley Feb 16, 2026
80e31fa
builders should be records.
dsmiley Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion solr/core/src/java/org/apache/solr/search/BitDocSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.util.Collections;
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.search.DocIdSetIterator;
import org.apache.lucene.search.Query;
import org.apache.lucene.util.Accountable;
import org.apache.lucene.util.BitSetIterator;
import org.apache.lucene.util.FixedBitSet;
Expand Down Expand Up @@ -320,7 +321,7 @@ public long cost() {
}

@Override
public DocSetQuery makeQuery() {
public Query makeQuery() {
return new DocSetQuery(this);
}

Expand Down
Loading
Loading