Skip to content

Comments

Reproduce AdminUI 401 during basicAuth#4107

Closed
janhoy wants to merge 2 commits intoapache:mainfrom
janhoy:bats-reproduce-admin-401
Closed

Reproduce AdminUI 401 during basicAuth#4107
janhoy wants to merge 2 commits intoapache:mainfrom
janhoy:bats-reproduce-admin-401

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Feb 6, 2026

Ref mailing list and slack discussions

janhoy and others added 2 commits February 6, 2026 01:01
Reverted whitespace-only edits (trailing space removal) while
preserving the new test case for admin UI basic auth exception.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@janhoy janhoy requested review from epugh and gerlowskija February 6, 2026 00:16
@epugh
Copy link
Contributor

epugh commented Feb 6, 2026

Test looks good.. I didn't think we could do it with curl!!!

@janhoy
Copy link
Contributor Author

janhoy commented Feb 6, 2026

cURL can do far more than your browser can, bro'

@janhoy janhoy marked this pull request as draft February 6, 2026 14:22
@dsmiley
Copy link
Contributor

dsmiley commented Feb 6, 2026

+1 bring this into SOLR-18102.
Thanks Jan!

'course Curl can do this... this bug is extremely testable. Lack of Selenium is no excuse either (as seen here).

@dsmiley
Copy link
Contributor

dsmiley commented Feb 6, 2026

It's a shame to have a BATS test for this versus a typical Solr JUnit test, that'd be way more efficient. Bats tests get run in serial; we have a boiling frog problem! Was Java/JUnit deemed hard?

@janhoy
Copy link
Contributor Author

janhoy commented Feb 6, 2026

It's a shame to have a BATS test for this versus a typical Solr JUnit test, that'd be way more efficient. Bats tests get run in serial; we have a boiling frog problem! Was Java/JUnit deemed hard?

It was useful as it closely resembles the CLI.

I'm sure JUnit could have revealed the same.

Perhaps a nice future task for an LLM - consider all BATS tests; if you find one that does not primarily exist to test CLI tool / shell script behavior, consider moving it to an ordinary JUnit test....

@janhoy janhoy closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants