refactor: replace interface{} with any for clarity and modernization#239
Merged
mrproliu merged 1 commit intoapache:mainfrom Feb 10, 2026
Merged
refactor: replace interface{} with any for clarity and modernization#239mrproliu merged 1 commit intoapache:mainfrom
mrproliu merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: jiangmencity <jiangmen@52it.net>
There was a problem hiding this comment.
Pull request overview
Refactors the public log.Logger interface to use Go 1.18+ any in place of interface{} to modernize type signatures and improve readability.
Changes:
- Replace
interface{}withanyinLogger.WithFieldand variadic logging methods (Info,Warn,Error, and*fvariants).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+23
| WithField(key string, value any) Logger | ||
| // Info logs to the INFO log. | ||
| Info(args ...interface{}) | ||
| Info(args ...any) |
There was a problem hiding this comment.
PR title/description suggests a broad replacement of interface{} with any across the codebase, but this PR (at least in the changes shown) only updates the log.Logger interface. Consider updating the PR description/title to reflect the narrower scope, or expanding the refactor to cover the remaining interface{} usages if that was the intent.
mrproliu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces occurrences of interface{} with the predeclared identifier any, introduced in Go 1.18 as an alias for interface{}.
As noted in the Go 1.18 Release Notes:
This improves readability and aligns the codebase with modern Go conventions.