PIP-121: Implement AutoClusterFailover#547
Open
BewareMyPower wants to merge 10 commits intoapache:mainfrom
Open
PIP-121: Implement AutoClusterFailover#547BewareMyPower wants to merge 10 commits intoapache:mainfrom
BewareMyPower wants to merge 10 commits intoapache:mainfrom
Conversation
BewareMyPower
force-pushed
the
bewaremypower/auto-cluster-failover
branch
from
1a1efd8 to
7b1ba7d
Compare
BewareMyPower
force-pushed
the
bewaremypower/auto-cluster-failover
branch
from
7b1ba7d to
5df139c
Compare
There was a problem hiding this comment.
Pull request overview
Adds an AutoClusterFailover implementation of ServiceInfoProvider to automatically switch the client’s service URL between a primary cluster and fallback clusters based on periodic TCP reachability probes, plus unit tests for basic failover/switchback behavior.
Changes:
- Introduces new public
pulsar::AutoClusterFailoverAPI (builder/config) and implementation with periodic probing and delayed failover/switchback. - Adds new tests exercising failover to an available secondary and switching back to primary after recovery.
- Makes
ServiceInfodefault-constructible to support the new builder/config construction pattern.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
lib/AutoClusterFailover.cc |
Implements the async probing + state machine for primary/secondary switching. |
include/pulsar/AutoClusterFailover.h |
Adds the public API (Config + Builder) for wiring AutoClusterFailover into Client::create(...). |
include/pulsar/ServiceInfo.h |
Adds a default constructor to ServiceInfo to enable default construction in the new builder/config. |
tests/ServiceInfoProviderTest.cc |
Adds probe-based tests for failover and switchback timing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.