Skip to content

ORC-2053: Use Java Set.of instead of Collections.emptySet #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
+6 −4
Closed

ORC-2053: Use Java Set.of instead of Collections.emptySet #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
<property name="ignoreComments" value="true"/>
<property name="message" value="No starting LAND and LOR allowed."/>
</module>
<module name="RegexpSinglelineJava">
<property name="format" value="Collections\.emptySet"/>
<property name="message" value="Use Set.of() instead." />
</module>
<module name="Indentation">
<property name="severity" value="error"/>
<property name="basicOffset" value="2"/>
Expand Down
3 changes: 1 addition & 2 deletions java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
import java.text.DateFormat;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -143,7 +142,7 @@ public static class ReaderContext implements Context {
private ReaderEncryption encryption;
private boolean useProlepticGregorian;
private boolean fileUsedProlepticGregorian;
private Set<Integer> filterColumnIds = Collections.emptySet();
private Set<Integer> filterColumnIds = Set.of();
Consumer<OrcFilterContext> filterCallback;

public ReaderContext setSchemaEvolution(SchemaEvolution evolution) {
Expand Down
3 changes: 1 addition & 2 deletions java/core/src/java/org/apache/orc/impl/reader/StripePlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
import java.security.Key;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -123,7 +122,7 @@ public StripePlanner(TypeDescription schema,
boolean ignoreNonUtf8BloomFilter,
long maxBufferSize) {
this(schema, encryption, dataReader, version, ignoreNonUtf8BloomFilter, maxBufferSize,
Collections.emptySet());
Set.of());
}

public StripePlanner(StripePlanner old) {
Expand Down
Loading