Serialization error when using sum on decimal values in aggregate expression #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2025 14:39
Ensures tests validate successful responses by checking status codes and reading from input streams instead of error streams. Removes extraneous semicolons for code style consistency. Adds Maven Invoker plugin to support integration testing scenarios.
Aligns all module parent references to the latest snapshot version to ensure consistency and enable development on the 5.0.2 release line. Facilitates dependency management and prepares for upcoming changes.
Introduces a mechanism to associate options, such as scale, with dynamic properties in aggregation expressions. Enhances flexibility for aggregate calculations, especially for methods requiring specific decimal precision. Improves property handling during parsing and type construction to better align with aggregation semantics. This implementation was necessary to fix an issue where aggregations using sum on decimal values caused errors in the JSON serializer due to missing scale information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Serialization error when using sum on decimal values in aggregate expressions
This PR addresses a bug where using the sum aggregation on decimal properties would lead to a JSON serialization error due to missing or inconsistent scale information.
To resolve this, support for dynamic property options (e.g., scale) was added, allowing the aggregation parser and type constructor to handle decimal precision correctly during aggregation.
Key changes:
Introduced support for dynamic property options in aggregate expressions.
Ensured scale is preserved and correctly applied during parsing and result construction.
Improved compatibility with JSON serialization by ensuring consistent type metadata.
This fix is essential for systems that rely on precise decimal aggregation and downstream serialization (e.g., REST APIs or JSON-based storage).