[WIP] boards/xtensa/esp32s3: New board WaveShare ESP32-S3-(Touch)-LCD-1.28.#18730
[WIP] boards/xtensa/esp32s3: New board WaveShare ESP32-S3-(Touch)-LCD-1.28.#18730cederom wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Do you have related defconfig or options that added on boards/xtensa/esp32s3/esp32s3-devkit/configs/txtable/defconfig? If not, it is better to remove.
There was a problem hiding this comment.
I did not see esp32s3_qmi8658.c, please check other files too
There was a problem hiding this comment.
Updated, added qmi8658 configuration for testing, did not use it myself yet :-)
eren-terzioglu
left a comment
There was a problem hiding this comment.
Thanks for adding new esp based board. Nice work, congrats
| if ARCH_BOARD_ESP32S3_WS_LCD128 | ||
|
|
||
| choice | ||
| prompt "BOARD VARIANT" | ||
| default ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH | ||
| help | ||
| There are two variants of the board with [1] and without [2] touch screen. | ||
| These boards also have slightly different signals and capabilities. | ||
| Non-touch variant has two connectors with many more GPIO available. | ||
|
|
||
| [1] https://www.waveshare.com/esp32-s3-touch-lcd-1.28.htm | ||
| [2] https://www.waveshare.com/esp32-s3-lcd-1.28.htm | ||
|
|
||
| NOTE: Touch screen driver is not yet implemented! | ||
|
|
||
| config ARCH_BOARD_ESP32S3_WS_LCD128_NOTOUCH | ||
| bool "NO-TOUCH ESP32-S3-LCD-1.28" | ||
| select LCD | ||
| help | ||
| Mark this choice if your board has no touch screen module installed. | ||
| www.waveshare.com/esp32-s3-lcd-1.28.htm | ||
|
|
||
| config ARCH_BOARD_ESP32S3_WS_LCD128_TOUCH | ||
| bool "TOUCH ESP32-S3-Touch-LCD-1.28" | ||
| help | ||
| Mark this choice if your board has touch screen module installed. | ||
| www.waveshare.com/esp32-s3-touch-lcd-1.28.htm | ||
|
|
||
| NOTE: Touch screen driver is not yet implemented! | ||
|
|
||
| endchoice |
There was a problem hiding this comment.
Hi @cederom , please correct the style of the Kconfig files.
- add TAB
- help -> ---help---
| * Name: board_lcd_getdev | ||
| * | ||
| * Description: | ||
| * Return a a reference to the LCD object for the specified LCD. This |
There was a problem hiding this comment.
Small typo
| * Return a a reference to the LCD object for the specified LCD. This | |
| * Return a reference to the LCD object for the specified LCD. This |
| } | ||
| else | ||
| { | ||
| lcdinfo("SPI port %d bound to LCD %d\n", DISPLAY_SPI, devno); |
There was a problem hiding this comment.
Keep using syslog instead of lcdinfo, as you use syslog right above.
There was a problem hiding this comment.
Updated to syslog.. but other implementations use lcdifo as this is part of lcd debug wrappers :-) Can update as needed in future too :-)
|
|
||
| syslog(LOG_INFO, "Initializing LCD SPI port."); | ||
|
|
||
| lcdinfo("Initializing SPI port %d\n", DISPLAY_SPI); |
There was a problem hiding this comment.
Personally I prefer to stick with syslog at board level instead of mixing syslog and lcdinfo. Either way we should stick to one
There was a problem hiding this comment.
updated, as above :-)
| CONFIG_DEBUG_FULLOPT=y | ||
| CONFIG_DEBUG_GPIO=y | ||
| CONFIG_DEBUG_GPIO_ERROR=y | ||
| CONFIG_DEBUG_LCD=y |
There was a problem hiding this comment.
See if all those debug options are needed for the defconfig
There was a problem hiding this comment.
removed! leftover from testing thanks! :-)
| CONFIG_DEBUG_ASSERTIONS_EXPRESSION=y | ||
| CONFIG_DEBUG_FEATURES=y | ||
| CONFIG_DEBUG_FULLOPT=y | ||
| CONFIG_DEBUG_GPIO=y |
There was a problem hiding this comment.
See if all those debug options are needed for this defconfig
There was a problem hiding this comment.
removed! leftover from testing thanks! :-)
|
Thank you @cederom! |
…IP). * Initial experimental / work in progress implementation. * New board name is esp32s3-ws-lcd128. * Supports Kconfig delectable w/wo touch variants (gpios difference). * Supported configurations: nsh, ostest, coremark, touch-lvgl, notouch-lvgl, qmi8658, watchdog. * Does not have touch panel driver yet. * Board documentation. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
ea2b297 to
185263d
Compare
|
Updated, thank you for checking folks! :-) Ah, typos and formatting, will update in few hours, have to go out now, sorry! <3 |
|
|
||
| config ARCH_BOARD_ESP32S3_WS_LCD128_TOUCH | ||
| bool "TOUCH ESP32-S3-Touch-LCD-1.28" | ||
| help |
There was a problem hiding this comment.
| help | |
| ---help--- |
There was a problem hiding this comment.
aaargh mea cupla o_O
Summary
[1] https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-1.28
Impact
Testing
Developed on FreeBSD 14.4, provided and testes basic configurations with nsh, ostest, coremark, watchdog, touch-lvgl (spawns lvgldemo on touch board variant), notouch-lvgl (non-touch board variant lvgldemo spawn).