!interpreters: Align naming of Kconfig options#3403
!interpreters: Align naming of Kconfig options#3403linguini1 wants to merge 5 commits intoapache:masterfrom
Conversation
Aligns `CONFIG_INTERPRETER_*` options to `CONFIG_INTERPRETERS_*` options to be consistent with other interpreters. BREAKING CHANGE: All configurations using `CONFIG_INTERPRETER_BAS_*` options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailing S following INTERPRETER in the affected Kconfig variables. I believe `./tools/refresh.sh` should also be capable of doing this automatically. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
Aligns `CONFIG_INTERPRETER_*` options to `CONFIG_INTERPRETERS_*` options to be consistent with other interpreters. BREAKING CHANGE: All configurations using `CONFIG_INTERPRETER_LUA_*` options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailing S following INTERPRETER in the affected Kconfig variables. I believe `./tools/refresh.sh` should also be capable of doing this automatically. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
Aligns `CONFIG_INTERPRETER_*` options to `CONFIG_INTERPRETERS_*` options to be consistent with other interpreters. BREAKING CHANGE: All configurations using `CONFIG_INTERPRETER_MINIBASIC_*` options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailing S following INTERPRETER in the affected Kconfig variables. I believe `./tools/refresh.sh` should also be capable of doing this automatically. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
Aligns `CONFIG_INTERPRETER_*` options to `CONFIG_INTERPRETERS_*` options to be consistent with other interpreters. BREAKING CHANGE: All configurations using `CONFIG_INTERPRETER_PYTHON_*` options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailing S following INTERPRETER in the affected Kconfig variables. I believe `./tools/refresh.sh` should also be capable of doing this automatically. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
Fix some spelling errors for CI. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
275d642 to
7de69ad
Compare
|
It appears the check is failing due to a lot of mixed-case identifiers in the bas interpreter. I solved the spelling errors, but please let me know if I should fixed the identifiers or leave them alone (since this code is taken from some original source outside NuttX). If there is a way I can make the check ignore these mixed-case identifiers, I can also implement that instead. |
|
Thank you @linguini1 :-)
|
Combination of both the fact that the subdir is called
Seems like a good name! I don't want to do that in this PR because it involves a breaking change for several more applications, and it seems we're tied to |
:-)
Maybe if we already introduce breaking change a discussion on the mailing list we could ask and change the name for shorter and more generic? :-P |
|
some build issues :-( |
I think it's because the defconfigs on NuttX don't use the updated names, which the twin PR fixes. This is one of those scenarios though where I don't think the CI will pass until both are merged. |
cederom
left a comment
There was a problem hiding this comment.
Thank you @linguini1 :-)
To be merged with apache/nuttx#18398 to pass the CI buils, mixed cases are part of existing code.
Summary
Aligns the Kconfig option naming for interpreters, fixes #2894.
BREAKING CHANGE:
All configurations using
CONFIG_INTERPRETER_*options will no longer compile due to missing symbol errors. The fix is very quick: any configurations using this options should add a trailingSfollowingINTERPRETERin the affected Kconfig variables. I believe./tools/refresh.shshould also be capable of doing this automatically.CONFIG_INTERPRETERS_*was chosen overCONFIG_INTERPRETER_*becausenuttx-apps/interpretersdir exists and because there were more existing configurations usingCONFIG_INTERPRETERS_*options. Breaks less things that way and is also intuitive.Depends-on: apache/nuttx#18398.
Impact
Cohesive naming. Affects all configurations using
CONFIG_INTERPRETER_*options.Testing
Verified build of configuration
sim:luaafter this change, which previouslyused
CONFIG_INTERPRETER_LUA_*options.Build logs:
Details
Using Lua interpreter logs:
Details