Fix broken reference links in site.xml for Maven 4.x #11617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reference menu links were using incorrect paths (impl/ and compat/) instead of the deployed site structure (maven-impl-modules/ and maven-compat-modules/), causing 404 errors on the production site. Fixed URLs: - Lifecycles: ./maven-impl-modules/maven-core/lifecycles.html - Plugin Bindings: ./maven-impl-modules/maven-core/default-bindings.html - Artifact Handlers: ./maven-impl-modules/maven-core/artifact-handlers.html - CLI options: ./maven-compat-modules/maven-embedder/cli.html - Super POM: ./maven-compat-modules/maven-model-builder/super-pom.html
There was a problem hiding this comment.
Pull request overview
This PR fixes broken reference menu links in the Maven site navigation by updating paths from outdated directory names (impl/ and compat/) to the current deployed site structure (maven-impl-modules/ and maven-compat-modules/). The changes address 404 errors reported in issue #2502 for the Maven 4.0.0-rc-4 reference documentation.
- Updates all five reference menu links to use correct module paths
- Changes from impl/maven-core/* to maven-impl-modules/maven-core/* for Lifecycles, Plugin Bindings, and Artifact Handlers
- Changes from compat/* to maven-compat-modules/* for CLI options and Super POM
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reference menu links were pointing to outdated paths (impl/ and compat/) that do not exist on the deployed Maven 4 reference site, resulting in 404 errors.
This PR updates the Reference menu URLs to match the current deployed site structure (maven-impl-modules/ and maven-compat-modules), fixing navigation for Lifecycles, Plugin Bindings, Artifact Handlers, CLI options, and Super POM.
Related to #2502.
