-
Notifications
You must be signed in to change notification settings - Fork 68
Fix typos and improve clarity in index.apt.vm #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes typos and improves clarity in the Maven Wrapper documentation file. The changes focus on correcting grammatical errors and enhancing readability in the APT format documentation.
- Capitalized "Maven" for consistency and proper noun usage
- Added missing articles ("the") for better grammatical structure
- Improved punctuation and sentence flow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| but every distribution has specific content to manage different strategies to get {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | ||
|
|
||
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download the maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. | ||
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. |
Copilot
AI
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'maven' at the end of the line should be capitalized to 'Maven' for consistency with the rest of the documentation where Maven is treated as a proper noun.
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>. | |
| - <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded Maven distribution, skipping <<<maven-wrapper.jar>>>. |
| ---- | ||
|
|
||
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>> source then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | ||
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: |
Copilot
AI
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'on *nix' should be capitalized to 'On *nix' since it begins a sentence.
| - <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: | |
| - <<<source>>>: On *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}: |
|
@elharo Please assign appropriate label to PR according to the type of change. |
No description provided.