Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Sep 12, 2025

No description provided.

@elharo elharo requested review from Copilot and hboutemy September 12, 2025 11:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos and improves clarity in the Maven Wrapper documentation file. The changes focus on correcting grammatical errors and enhancing readability in the APT format documentation.

  • Capitalized "Maven" for consistency and proper noun usage
  • Added missing articles ("the") for better grammatical structure
  • Improved punctuation and sentence flow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

but every distribution has specific content to manage different strategies to get {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}:

- <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download the maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>.
- <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>.
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'maven' at the end of the line should be capitalized to 'Maven' for consistency with the rest of the documentation where Maven is treated as a proper noun.

Suggested change
- <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded maven distribution, skipping <<<maven-wrapper.jar>>>.
- <<<only-script>>>: the new lite implementation of <<<mvnw>>>/<<<mvnw.cmd>>> scripts will download Maven directly with <<<wget>>> or <<<curl>>> on *nix, or PowerShell on Windows, then exec/call the original <<<mvn>>>/<<<mvn.cmd>>> scripts of the downloaded Maven distribution, skipping <<<maven-wrapper.jar>>>.

Copilot uses AI. Check for mistakes.
----

- <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>> source then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}:
- <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}:
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'on *nix' should be capitalized to 'On *nix' since it begins a sentence.

Suggested change
- <<<source>>>: on *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}:
- <<<source>>>: On *nix, if <<<wget>>> and <<<curl>>> are not available, the <<<mvnw>>> script will compile <<<MavenWrapperDownloader.java>>>, then run the class to download {{{../maven-wrapper/}<<<maven-wrapper.jar>>>}}:

Copilot uses AI. Check for mistakes.
@elharo elharo requested a review from cstamas September 17, 2025 15:42
@elharo elharo merged commit b4b8997 into master Sep 17, 2025
54 checks passed
@elharo elharo deleted the elharo-patch-1 branch September 17, 2025 18:46
@github-actions
Copy link

@elharo Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 3.3.4 milestone Sep 17, 2025
@elharo elharo added documentation Improvements or additions to documentation skip-changelog Skip this PR from automatically changelog generation labels Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants