IGNITE-28075 Make writeBufferSize for RocksDB log storage configurable#7724
Merged
rpuch merged 1 commit intoapache:mainfrom Mar 9, 2026
Merged
IGNITE-28075 Make writeBufferSize for RocksDB log storage configurable#7724rpuch merged 1 commit intoapache:mainfrom
rpuch merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a node-local configuration knob to tune RocksDB write buffer sizing for the partition raft log storage, wiring it through log storage manager creation and validating it via an integration test.
Changes:
- Introduce
RocksDbLogStorageOptionsand pass options intoDefaultLogStorageManagerfor RocksDB-specific tuning. - Wire partition raft log storage creation to read
ignite.system.properties.partitionsRaftLogStorageWriteBufferSize. - Add an integration test verifying the configured
writeBufferSizeis applied.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java | Passes partition-specific RocksDB log storage options into shared log storage manager creation. |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/util/SharedLogStorageManagerUtils.java | Adds overload to supply RocksDbLogStorageOptions to DefaultLogStorageManager. |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/RocksDbLogStorageOptions.java | New options holder that reads partition raft log write buffer size from system local properties. |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageManager.java | Applies configurable writeBufferSize and derives related RocksDB compaction sizing from it. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageManagerTest.java | Updates test construction to use the new DefaultLogStorageManager constructor signature. |
| modules/raft/src/integrationTest/java/org/apache/ignite/internal/raftsnapshot/ItLogStorageConfigurationTest.java | New IT asserting configured writeBufferSize is reflected in RocksDB column family options. |
| modules/raft/build.gradle | Adds RocksDB JNI dependency to the integration test classpath. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...aft/src/main/java/org/apache/ignite/internal/raft/storage/impl/RocksDbLogStorageOptions.java
Show resolved
Hide resolved
...aft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageManager.java
Show resolved
Hide resolved
...aft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageManager.java
Show resolved
Hide resolved
...egrationTest/java/org/apache/ignite/internal/raftsnapshot/ItLogStorageConfigurationTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28075