IGNITE-28007 split TablePartitionResourcesFactory out of TableManager#7701
Open
dant3 wants to merge 3 commits intoapache:mainfrom
Open
IGNITE-28007 split TablePartitionResourcesFactory out of TableManager#7701dant3 wants to merge 3 commits intoapache:mainfrom
dant3 wants to merge 3 commits intoapache:mainfrom
Conversation
ivanzlenko
reviewed
Mar 9, 2026
|
|
||
| @Override | ||
| public String toString() { | ||
| return S.toString(this); |
Contributor
There was a problem hiding this comment.
Are you sure we need this?
|
|
||
| fullStateTransferIndexChooser = new FullStateTransferIndexChooser(catalogService, lowWatermark, indexMetaStorage); | ||
|
|
||
| partitionResourcesFactory = new TablePartitionResourcesFactory( |
Contributor
There was a problem hiding this comment.
Can we create this factory in IgniteImpl and just insert it as a dependency into TableManager?
Contributor
Author
There was a problem hiding this comment.
We can't because this factory depends on some things that are created inside of the TableManager currently. This also makes the surface of the change way bigger than ideal.
| MvGc mvGc, | ||
| FullStateTransferIndexChooser fullStateTransferIndexChooser | ||
| ) { | ||
| this.txManager = requireNonNull(txManager, "txManager"); |
Contributor
There was a problem hiding this comment.
I wouldn't be bothered with checks tbf. We have annotations for that purpose.
ivanzlenko
reviewed
Mar 9, 2026
| catalogService, | ||
| table.schemaView(), | ||
| indexMetaStorage, | ||
| topologyService.localMember().id(), |
Contributor
There was a problem hiding this comment.
Small nitpick, we can cache id.
ivanzlenko
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28007
Key change points:
preparePartitionResourcesAndLoadToZoneReplicaBusy- split creation and lifecycle concernsregisterPartitionTableStatsMetrics— now registerspendingWriteIntentsSuppliers(was previously done insidecreatePartitionUpdateHandlers). The upstream also changed the metric from register-only to register-and-enable.unregisterPartitionMetrics— extracted as a separate method from the inline code in the table-drop path. Takes(TablePartitionId, String tableName)instead of accessingtable.name()directly.