[do not merge] testing zizmor and codeql checks #15794
Open
kevinjqliu wants to merge 3 commits intoapache:mainfrom
Open
[do not merge] testing zizmor and codeql checks #15794kevinjqliu wants to merge 3 commits intoapache:mainfrom
kevinjqliu wants to merge 3 commits intoapache:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Script injection via pr title | ||
| run: | | ||
| echo "Processing PR: ${{ github.event.pull_request.title }}" |
Check failure
Code scanning / CodeQL
Code injection Critical
|
|
||
| - name: Script injection via pr body | ||
| run: | | ||
| echo "${{ github.event.pull_request.body }}" |
Check failure
Code scanning / CodeQL
Code injection Critical
Comment on lines
+51
to
+53
| - name: Run untrusted code from PR | ||
| run: | | ||
| bash ./scripts/greet.sh |
Check failure
Code scanning / CodeQL
Checkout of untrusted code in a privileged context Critical
Contributor
Author
There was a problem hiding this comment.
nice! so even though this workflow is marked with on: pull_request_target # zizmor: ignore[dangerous-triggers], CodeQL still catches potential vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeql check #15348
zizmor check #15793