Fix HoodieStorage resource leak in FileSystemBasedLockProvider.close()#18461
Open
mailtoboggavarapu-coder wants to merge 1 commit intoapache:masterfrom
Open
Conversation
Collaborator
Contributor
Author
mailtoboggavarapu-coder
left a comment
There was a problem hiding this comment.
Pinging for an initial review. This PR fixes a genuine resource leak: FileSystemBasedLockProvider creates a HoodieStorage (which holds underlying filesystem connections and implements Closeable) in its constructor but never closes it in close(). The fix is a one-liner — calling storage.close() inside the existing close() method so the resource is released every time the lock provider is torn down.
Would appreciate a review from a committer with write access to apache/hudi (@vinothchandrasekar / @alexeykudinkin / @danny0405 / @nsivabalan).
danny0405
reviewed
Apr 15, 2026
| try { | ||
| storage.close(); | ||
| } catch (IOException e) { | ||
| LOG.warn("Failed to close storage in FileSystemBasedLockProvider", e); |
Contributor
There was a problem hiding this comment.
good catch, can you fix the indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FileSystemBasedLockProvidercreates aHoodieStorageinstance in its constructor but never closes it in theclose()method. SinceHoodieStorageimplementsCloseableand holds underlying filesystem connections, this causes a resource leak every time the lock provider is closed.Solution
Add a
finallyblock insideclose()to ensurestorage.close()is always called after the lock file deletion attempt, regardless of whether deletion succeeds or throws an exception. IOException fromstorage.close()is caught and logged as a warning to avoid masking the original exception.Changes
FileSystemBasedLockProvider.java: Addedfinallyblock inclose()to callstorage.close()with proper exception handling.