Skip to content

fix: JDBC connection leak in HiveIncrementalPuller.saveDelta() #18460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mailtoboggavarapu-coder wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −1
Open

fix: JDBC connection leak in HiveIncrementalPuller.saveDelta() #18460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cebe38e
fix: JDBC connection leak in HiveIncrementalPuller.saveDelta()
mailtoboggavarapu-coder Apr 16, 2026
840d140
fix: remove extra closing brace in saveDelta() that caused compile error
mailtoboggavarapu-coder Apr 16, 2026
b8b066f
fix: address review feedback from @yihua
mailtoboggavarapu-coder Apr 17, 2026
74c74ea
ci: re-trigger CI for spark3.5 flaky test
mailtoboggavarapu-coder Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ public void saveDelta() throws IOException {
conf.set("fs.defaultFS",config.fsDefaultFs);
FileSystem fs = FileSystem.get(conf);
Statement stmt = null;
Connection conn = null;
try {
if (config.fromCommitTime == null) {
config.fromCommitTime = inferCommitTime(fs);
Expand All @@ -145,7 +146,7 @@ public void saveDelta() throws IOException {
lastCommitTime = config.fromCommitTime;
}

Connection conn = getConnection();
conn = getConnection();
stmt = conn.createStatement();
// drop the temp table if exists
String tempDbTable = config.tmpDb + "." + config.targetTable + "__" + config.sourceTable;
Expand All @@ -172,6 +173,16 @@ public void saveDelta() throws IOException {
} catch (SQLException e) {
LOG.error("Could not close the resultSet opened ", e);
}
try {
Connection toClose = (conn != null) ? conn : this.connection;
if (toClose != null) {
toClose.close();
}
} catch (SQLException e) {
LOG.error("Could not close the JDBC connection", e);
} finally {
this.connection = null;
Copy link
Copy Markdown
Contributor

@yihua yihua Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit: the nested finally block here makes the structure confusing — could simplify by moving this.connection = null; outside the try-catch since setting a field to null doesn't throw.

- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

}
}
}

Expand Down
Loading